| commit | 982b82bb0ed0f55c5bfd76a6b5cc1affef8368db | [log] [tgz] |
|---|---|---|
| author | Ian Kilpatrick <ikilpatrick@chromium.org> | Fri May 27 01:43:35 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri May 27 01:50:14 2022 |
| tree | acbac1cddbeb5c72cc1ecae4cee27d80354a2d56 | |
| parent | b28e5b14195e0d1614a4a39eb44407747f8b54d9 [diff] |
[TableFragmentation] Fix collapsed borders near fragmentation boundaries This does some fixes to collapsed borders around fragmentation boundaries. Firstly it excludes the over/under border from the joint calculation when at a fragmentation boundary. This prevents the border seemingly having a random joint color when fragmentation is present. We check if we should draw a "half" border if we are at a fragmentation boundary, and we know we have previous/next table content. We check this by looking at the row indices to determine if there are subsequent rows. I've made the test .tentative as the joint logic isn't really written down anywhere, and everyone has bad behaviour here. Bug: 1078927 Change-Id: I7a12458bb128f3a6650b2a408cef218ae1093dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3662014 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008101}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!