commit | b28e5b14195e0d1614a4a39eb44407747f8b54d9 | [log] [tgz] |
---|---|---|
author | Nate Chapin <japhet@chromium.org> | Fri May 27 00:44:32 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri May 27 01:00:42 2022 |
tree | d48b2f501005391d6fa3b3ee5d10e643eef9f939 | |
parent | a1bd260577b12452d0ec9e4248e000f082511166 [diff] |
Properly handle non-current entries with no NavigationApi state 1. The NavigationApiHistoryEntry mojom struct doesn't allow a null string representation of the the state object, which confuses deserialization when no state object is set. 2. When the state object is updated, it does not immediately get synced to the browser process. This is because it is either set shortly after commit for ordering reasons (and so misses the sync that happens during commit), or is updated by navigation.updateCurrentEntry() (which is not treated as a navigation, so there is no commit). This is problematic because the navigation api state object can be exposed on other same-origin documents, and that state is gathered in the browser process commit logic, which is too early for the renderer's "last chance" sync during unload. When that happens, the next document's entry for for the previous document has an out-of-date state object. Introduce a mechanism to force an immediate history sync outside of the commit/freeze/unload ones, and use it when navigation api state is updated. Bug: 1326246 Change-Id: Ie62bf0791c0e366258a32a5e62f193d5597de5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3662189 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008064}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!