commit | 76bd0b1aee55e55bece826094be696f4c1ee54fa | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue May 31 05:38:45 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue May 31 05:53:14 2022 |
tree | 087cc9057020fff8ae7d2c17f281d47fbeb81826 | |
parent | 206237ada60313f3fe1c6cf36e3117fd5de30fb6 [diff] |
Pass parent constraint space to child space builder when possible. Prefer using the NGConstraintSpaceBuilder(const NGConstraintSpace& parent_space...) constructor, when possible. It inherits a flag from the parent - "ShouldPropagateChildBreakValues". Failing to inherit this inside the table layout code was actually causing bugs (see test included). The real motivation behind this change, though, is that I'm planning on adding one more flag here for repeated content (repeated table headers / footers, and also fixed-positioned elements when printing). The changes here are all about tables and out-of-flow positioning. We can now get rid of a couple of members from NGOutOfFlowLayoutPart. At the same time, now that we're using the NGConstraintSpaceBuilder that takes a constraint space, we can no longer "cheat" about what the parent's writing mode is. So NGOutOfFlowLayoutPart::GenerateFragment() needs to convert the size of the child from the writing-mode of the child to the writing-mode of the container, and pass that as available size to the constraint space builder. LayoutNGMixin<Base>::UpdateOutOfFlowBlockLayout() was also passing an incorrect constraint space to NGOutOfFlowLayoutPart. It should be created based on the container, NOT the child. Because of this change, we now need to remove the DCHECK for formatting context root from NGConstraintSpace::CreateFromLayoutObject(), since we may now end up here even if the containing block isn't a formatting context root. But that's okay, as long as we're not going to lay it out. Re-add [1] an equivalent DCHECK to UpdateInFlowBlockLayout(). [1] Was removed in CL:1473393, in favor of the one in CreateFromLayoutObject(), which now is gone. Bug: 1078927 Change-Id: I28783925326df87311c9894b72f898525daa5811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3673761 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008987}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!