commit | f9f92eee53bce592b666f3a9d2677738d7f61377 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Wed Jun 08 08:33:50 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jun 08 08:47:30 2022 |
tree | f1726c850fc26b011248b08e76298a2dc5a2b136 | |
parent | f19ad26c18832e8ff7da89e855ad6c71e449056f [diff] |
Support for repeated table headers and footers in fragmentation. This adds support for repeated table headers and footers to the NG table fragmentation engine, and also generic block fragmentation support for repeated content. The latter will also be needed in order to support repeated fixed-positioned elements for printing, in the future. Ideally, we shouldn't really have to clone the fragments generated by repeatable content, but rather just insert the same fragment into every parent table fragment, but that's currently not possible, because of pre-paint, paint, and possibly other things too. Pre-paint and paint rely on FragmentData objects, which contain the "global-ish" paint offset for each fragment, so, unless we want to add logic for this on the pre-paint / paint side, this will have to do for now. Add an NGFragmentRepeater class, which takes care of the fragment cloning. It will create a deep clone of the fragment subtree, and update the break tokens, to tie everything together (so that it's only the final fragment that doesn't have a break token), and set correct sequence numbers. This way pre-paint and paint will work correctly "out of the box". This fixes some existing (non-WPT) tests. Wrote a few more (WPT) tests, to shed some light on some of the issues that we need to handle. I thought about different ways of implementing this, such as actually laying out every repeated fragment, rather than cloning them, but that proved to be difficult, since we also have to repeat monolithic content, including atomic inlines, and also multicol (in addition, this approach would introduce a lot of repeated node awareness to the layout engine, which I think we're better off without). So just cloning the whole fragment tree turned out to be easier. Keeping this as simple as possible is important, especially since, with any luck, at some point in the future, we may be able to just re-use the same fragment for each repetition. Bug: 1078927 Change-Id: Ie1c9ce587f875716349e5bf1169c6c84f409d4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3689493 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1011833}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!