commit | caea13fbbb683d4a35b4e8e431ecb4b8d0ace7ac | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Mon Jul 11 23:50:35 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jul 12 00:04:01 2022 |
tree | af01b29d2e264f36add41576d09e11afe182d3c6 | |
parent | 52b3307a5be5a03c10df2d96c96191575386be7b [diff] |
Revert "[bindings] always return value from Window self-referential getters" This reverts commit 8024b6f1104c31cc7911a0776a6b9480b8aa59a3. Reason for revert: The following test modified by the original CL is flaky on Linux bot. external/wpt/html/browsers/the-window-object/window-properties.https.html https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/118506/overview Original change's description: > [bindings] always return value from Window self-referential getters > > For whatever reason, some operations seem to invalidate the CacheAccessor unnecessarily. Rather than marking a bunch of operations as being side-effect free incorrectly, or finding another work around, it seemed the simplest solution was to simply return the v8 wrapper from the accessor. To achieve this, the wrapper object the method is invoked on is returned. The [CrossOrigin] IDL attribute remains, and the previous method of looking up the correct wrapper for a window in a detached frame is still used. > > BUG=1305302 > > Change-Id: I2fb0f0fb9d59511debe9e009a6f3194b48ca29b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715140 > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1022719} Bug: 1305302 Change-Id: I87a57bce462d69cb3919166abb1af14df50ac67d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3756242 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#1022959}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!