commit | 77d05b2b2cdecc1dfad3967d38a0300c702a8dc0 | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Fri Jul 15 21:47:36 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jul 15 22:04:03 2022 |
tree | 5d572bc0d872292cb4aa02e14f2a93048aa4ae61 | |
parent | 92c5a8f1b91f56c0e39a989138b9431d4b9b381d [diff] |
[LayoutNG] OOFs and column balancing OOFs currently only affect the initial column balancing pass, but we want them to affect column balancing on later passes, too. To do so, we need to lay out the OOFs during column layout. Currently, though, OOFs are laid out at the end of multicol layout (to ensure the containing block has completed layout). However, we can perform layout earlier for OOFs whose CB hasn't broken so that they affect column balancing. The problem is that these columns haven't been added to the builder at the time when the columns are being balanced, so the OOFs haven't been propagated up to the builder, either. To address this, add a new ColumnBalancingInfo struct to hold the current columns so that NGOutOfFlowLayoutPart will know which columns to use. This will also store a list of OOFs so that we can propagate the OOFs to this struct rather than to the builder. This struct will then be passed into HandleFragmentation() so that a special layout pass can be run on the current unbalanced columns, where we will propagate the info needed to successfully affect column balancing (such as the minimal space shortage, # of new columns added, and if there was a violating break). This special layout pass won't update the builder (i.e. the OOF results aren't added and new columns aren't created). Since we don't actually add the OOFs in this pass to the builder, we will continue to lay out the OOFs at a later point (as is currently done) where they will be officially laid out and added to the builder. Note that out-of-flow-in-multicolumn-099.html passed previously to this CL since break-inside:avoid doesn't affect the OOF. This was simply added to make sure that case was working as expected. Bug: 1341358 Change-Id: Ic1fa6b57a8e4fa26a3f0e1acbd2efe7425787ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3761109 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1024906}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!