commit | 2364c1455ef1e64ee7333f83d3626ab825227580 | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Tue Aug 16 13:24:36 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 16 13:31:22 2022 |
tree | 0eeb6d817b34564308ae71f9e6b9cc7b44820c7e | |
parent | f79b2135201e4c82674d114ef4aba1f8ca4e57f1 [diff] |
HighlightInheritance: fix ‘currentColor’ for all other properties Highlight pseudos have a special case for ‘color:currentColor’, where it means the ‘color’ of the next active highlight layer below, rather than being equivalent to ‘color:inherit’. This not only means that the ‘color’ of a highlight might be unknown until paint determines where the highlights are active, but so can any other property with <color> values, thanks to ‘currentColor’. HighlightPaintingUtils contains the logic for this, but currently only for ‘color’ and ‘background-color’, and even then the latter is bugged since it always checks whether the *unvisited* value is currentColor. The general approach of having only Color-returning methods plus bool methods telling you whether to use them is also prone to bugs, since we can just blindly use the Color without checking. The ideal interface for highlights is for VisitedDependentColor and the ColorIncludingFallback methods to return optional<Color>, but we also don’t want to penalise non-highlight code with all of these extra optional checks, nor do we want to maintain two copies of the code. This patch adds an optional bool out parameter to • ComputedStyle::VisitedDependentColor • Longhand::ColorIncludingFallback • StyleColor::Resolve and the helper functions • ComputedStyle::ResolvedColor • ComputedStyle::GetCurrentColor • ComputedStyle::GetInternalVisitedCurrentColor • ComputedStyle::GetInternalForcedCurrentColor • ComputedStyle::GetInternalForcedVisitedCurrentColor • ComputedStyleUtils::BorderSideColor • StyleColor::ResolveWithAlpha that (if present) indicates whether the property that was ultimately chosen was ‘currentColor’, while resolving the color as usual. We also remove the old functions for handling ‘currentColor’ in highlights: • ComputedStyle::IsBackgroundColorCurrentColor • ComputedStyle::VisitedDependentColorIsCurrentColor This in turn allows us to create HighlightPaintingUtils::ResolveColor, which encapsulates the “property color or this layer currentColor or previous layer currentColor or originating currentColor” dance. While this patch won’t completely prevent misuse of the Color-based interface, the new helper in HighlightPaintingUtils should at least make the correct logic easy enough to discourage it. Bug: 1295264 Change-Id: Ic0e5ee6787162b33172b9f7023e404c82be1b14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781986 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1035475}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!