| commit | 260ab29a061a7bb48dc8eb9b45c2276c1fb183ac | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Wed Aug 24 12:09:10 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Aug 24 12:21:41 2022 |
| tree | de951c9b56d0ec3d9229c27eec195fce00198d13 | |
| parent | 3fe0bbd42b7f71b3d5e19fe8306e353081b8a85f [diff] |
[scroll-animations] Recalculate siblings if needed Due to how the named timeline lookup works, it is now possible for the computed style of an element to depend on the style of a previous sibling. This requires a new kind of StyleRecalcChange::Propagation which can "upgrade" the style recalc of an element to also include the subsequent siblings (and their descendants). In order to do this, Element::RecalcStyle now returns a StyleRecalcChange which is intended to be combined with an outer StyleRecalcChange to "upgrade" the recalc severity at the call-site. - If we are already in ContainerNode::RecalcDescendantStyles, then that's effectively a sibling traversal from the perspective of a given child. So we can piggy-back on that traversal in this case. - Otherwise, if the sibling-recalc-triggering element is the recalc root itself, the new ContainerNode::RecalcSubsequentSiblingStyles function will handle it. Note that the following things are deliberately ignored in this CL: - ShadowDOM - Forced style updates (NeedsLayoutTreeUpdateForNode) Bug: 1317765, 1356098 Change-Id: Ib78d8815449318420d6aab09dc671a2b5f0a168f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833551 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1038718}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!