commit | 79eaf42c932d8f08f1784562ba4d975e4abb272d | [log] [tgz] |
---|---|---|
author | Masayuki Nakano <masayuki@d-toybox.com> | Mon Sep 12 23:58:32 2022 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Tue Sep 13 09:44:01 2022 |
tree | 136361f31df4c6482796a2938c80b6f9b3d29f1f | |
parent | 32a29b627ee8b74f16e63c2041880e870c746ebd [diff] |
Make `SelectionState::DidMoveNode` track DOM points having pointed the moved content correctly When selection is `abc<b>[def</b>]ghi`, `insertParagraph` command will delete the `<b>` element first, then, `Selection` becomes `abc{}ghi`. Then, `HTMLEditor::InsertParagraphSeparatorAsSubAction` wraps all of the line in the default paragraph, `<div>`, with `HTMLEditor::FormatBlockContainerWithTransaction` (although this is incompatible behavior with the other browsers). At this time, new `<div>` is inserted before the first text node and then, move the text nodes into the new `<div>`. However, `RangeUpdater::DidMoveNode` just slides the offsets if containers of registered DOM points are the ex-parent of the moving nodes. Therefore, the tracked selection range in `HTMLEditor::FormatBlockContainerWithTransaction` become `<div></div>abc{}def`, then, `<div>abcdef</div>{}`, but the expected behavior is of course, `<div>abc{}def</div>`, then, split the new `<div>`. So the problem is, `DidMoveNode` assumes that DOM points won't point the moving content node. If the node is pointed, it should keep pointing in the new parent. Note that the expectations of new tests are based on Chrome, therefore, the new known failures are incompatible with Chrome. Differential Revision: https://phabricator.services.mozilla.com/D156798 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1789344 gecko-commit: 713c1697c55581b86fd4a6d267d2f032090da0ca gecko-reviewers: m_kato
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!