| commit | 2d4b4312dc146c31ac6e836bcbf5ffe026a3ec4c | [log] [tgz] |
|---|---|---|
| author | Daniel Holbert <dholbert@cs.stanford.edu> | Mon Sep 19 20:39:57 2022 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Tue Sep 20 09:47:06 2022 |
| tree | 5c77611e2d5b182fdfbb4b29bdac26f21847cc56 | |
| parent | 86d251acc8f2176cda0177e900f551d939de5c8f [diff] |
Ignore 'align-content' when determining the aligned static position of abspos flex children. Before this patch, we honored `align-content` (in combination with `align-self`) for cross-axis alignment for abspos flex children **in cases where the flex container was multi-line**. This was a bit weird, but was required by the spec, and made some sense in the spirit of aligning the abspos box as if it were the sole flex item in a flex container. Now the CSSWG has resolved in [1] to simplify things by just ignoring `align-content` for abspos flex children. So, this patch updates us in accordance with this change. Such items now only have to look at `align-self` for cross-axis alignment to determine their static position in their flex container. Before this commit, we had a bunch of WPT tests to check the impact of every align-content value, with all of the various flavors of directionality. Now that align-content has *no effect* in any of these cases, all of these tests become pretty trivial and redundant. Rather than carrying them all forward with trivial "no impact" expectations for each scenario, I've just updated the first/simplest such test to expect no-behavioral-impact and I've removed the rest. [1] https://github.com/w3c/csswg-drafts/issues/7596#issuecomment-1225952646 Differential Revision: https://phabricator.services.mozilla.com/D157571 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1786910 gecko-commit: e2ea415fa03ccc085adee3bdaec2ab53a25993d0 gecko-reviewers: TYLin
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!