commit | 8d540ea766606fe1e44bfc8bc88b6918dfed982c | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Oct 13 08:29:27 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Oct 13 08:42:01 2022 |
tree | 61f558fdef8b3ba55f53e230ad937eb875e73e58 | |
parent | 97d663a6d409d3a34f456a743c31092f14371bdc [diff] |
Treat -webkit-line-clamp boxes as monolithic. It seems pointless to let them fragment, and our implementation didn't behave when they fragmented anyway. Apart from counting lines incorrectly in resumed fragments, we also had a stack overflow issue, due to RelayoutIgnoringLineClamp() and RelayoutAndBreakEarlier() invoking each other indefinitely. RelayoutIgnoringLineClamp() would kick in if the number of lines was equal to the -webkit-line-clamp value, regardless of whether there'd be more lines to come in the next fragmentainer. When going back to re-layout after having determined the orphans/widows requirements (RelayoutAndBreakEarlier()) and set an early-break, this could trigger RelayoutIgnoringLineClamp(), which would restart orphans/widows calculation, since the early-break wasn't carried over (this could be fixed, but it seems rather meaningless). Making such boxes monolithic will disable fragmentation inside, so that the two re-layout mechanisms never meet and therefore never get an opportunity to start fighting each other. We used to crash when printing youtube.com. Bug: 1372637 Change-Id: I3c3a072d9d5025205e6d3600738329df8d3da0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3948644 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1058563}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!