commit | 0b90ee44c7d6924e0328abead70fd17ee4b3015a | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Wed Oct 19 14:23:31 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Oct 19 14:31:21 2022 |
tree | 28a060e49545ae2cc338de6641ccdd68685cffae | |
parent | 1774ecf6c03b184d583fbacb1d3f05f946452762 [diff] |
Conditionally use initiator for about:blank navigations The HTML Standard demands that for new browsing context group creation, the initiator document's full URL (uncensored by referrer policy) be used as the new document's `document.referrer`. https://crrev.com/c/3763042 first implemented this change, however it made the assumption that whenever the initiator frame token is set, the initiator frame is present and can be referenced. Due to form submission scheduling, the initiator document might no longer exist by the time we try and synchronously navigate the new document to `about:blank` (via the form submission), and as a result we were null-dereferencing the initiator that is already done. This CL fixes the bug by only referencing the initiator document during new document creation *if* the new document exists (not just if the initiator frame token was set). This technically violates the spec, but the test I add in this CL ensures that: 1. The crash is fixed 2. The correct spec expectations are in place, despite us failing I'm considering changing the spec in this instance anyways, since it might not make sense for the spec strongly reference the initiator if it might not exist otherwise, but that is a separate issue. R=rakina@chromium.org Bug: 1370425 Change-Id: Ib34bee1211afec90e57a7cd804fc80f84a04e0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963738 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1061005}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!