| commit | 81f44f7ffc453cb0843739e3127e518d7f9e158d | [log] [tgz] |
|---|---|---|
| author | William Liu <liuwilliam@chromium.org> | Mon Oct 31 12:11:21 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Oct 31 12:26:25 2022 |
| tree | de57f74046aa49aee5724b2cc0080daa27ae7415 | |
| parent | a55edc9c5b5928dc195b63a625cba6936fa3fa8c [diff] |
Populate PerformanceNavigationTiming::deliveryType with the value "navigational-prefetch". Per https://github.com/WICG/nav-speculation/pull/180, PerformanceNavigationTiming::deliveryType will have value "navigational-prefetch" if the navigation is toward a prefetched URL. PrefetchService now sets a new enum on the response header, which will be checked in NavigationRequest::CommitNavigation for its value. If the value is kNavigationPrefetch, NavigationRequest::CommitNavigation sets the new navigational_delivery_type entry in the CommitParam, which is eventually sent to the renderer side DocumentLoader, used to construct the PerformanceNavigationTiming object. With this CL, the delivery_type_ of PerformanceResourceTiming and PerformanceNavigationTiming is set by the following: "navigational-prefetch" always takes highest precedence if presented; else, delivery_type_ is deduced by the cache state. TAO is not tested because we always observe the navigation timing at the destination, which is always same-origin to the document (prefetched or not). This matches the behavior of PerformanceNavigationTiming::AllowTimingDetails [1], that TAO check passes unconditionally. The WPT will remain tentative until the spec is updated. [1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/timing/performance_navigation_timing.cc;drc=87d6bd2db3e1ac920d1e289126bf264a2a9a313f;l=111 Bug: 1358591 Low-Coverage-Reason: tested by WPT. Change-Id: I5db2d6aaa05a15afb0a5d769d4474088a67c75bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3976228 Commit-Queue: William Liu <liuwilliam@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Max Curran <curranmax@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1065435}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!