commit | 5a19417ae2a59dac9fe61947132cac98feaeb5b6 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Oct 27 21:37:38 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Oct 27 21:45:36 2022 |
tree | ef1cc66d2ce8c1bd29c53f25e20577b8ffc37228 | |
parent | 4a9fb22ca75cb6997dc0571859e6762701eeaf7e [diff] |
Ignore repeated table sections in the block fragmentation machinery. This means adjusting the fragmentainer block-offset to where it would have been without any repeated table header, and shrink the fragmentainer block-size to exclude both the repeated header and the repeated footer (if any). We used to end up in an infinite loop if there was tall monolithic content after a repeated header, because we'd allow a break before it, even if we hadn't placed any content yet. But if the fragmentainer block-offset is 0 at this point, we'll refuse to break. We either need a positive fragmentainer block-offset, or at the very least, already having laid out some content (even if it has zero block-size), in order to allow a break. We had similar problems with repeated headers when border-spacing was larger than the block-size of the fragmentainer. In addition to the block-size of the header itself, just exclude border-spacing preceding the repeated header and the border-spacing that comes after the repeated header, so that whatever (a non-repeated section) comes right after that is seen as the start of the fragmentainer (lest we be tempted to break there). The correctness test included isn't very spectacular (although it neither freezes nor shows any red), since the repeated header had to be invisible, in order not to trigger crbug.com/1378607 . We create too many fragments in this case, because there's some problem with the table layout code that doesn't handle fragmentainer overflow correctly, resulting in a taller table than what we should have, and therefore excess fragmentainers. Bug: 1378576, 1378661 Change-Id: I938cb01a83d293bef5e8953248b726f01353dcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3981856 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1064548}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!