commit | f51f92b6c8682fde9f65f40410527028190f8cb7 | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Tue Nov 01 20:00:01 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 01 20:15:52 2022 |
tree | 3b105e861eb68c520748fdf63ff861e45c1ae520 | |
parent | 19f106fde863681fcce17bcf4f763eefce80bbcd [diff] |
[anchor-position] Fix a crash with scroller without overflow When a scroller's content doesn't overflow, there will be a non-null PaintLayerScrollableArea on it, but no corresponding scroll translation TransformPaintPropertyNode since there's nothing to scroll. This patch fixes a crash in this case by filtering out such scrollers from AnchorScrollData, and adds DCHECKs to verify it. Bug: 1371217 Change-Id: I99d794bb78da75750ff7ebb57a657b5f276b7691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3994190 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1066073}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!