commit | 23120473986805392b2e06e317cf49edf1dd8ab3 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Tue Nov 15 17:36:36 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 15 17:51:27 2022 |
tree | bfb89926f917e40ecd2851d9db9d315faad42490 | |
parent | 001870c82cc698c71e39c208171a9e5a236955b4 [diff] |
Discard FragmentData entries that are no longer represented. A re-layout may cause columns to appear and disappear, which may shuffle the fragment IDs around. If a new column has been added, which doesn't have an NG fragment for a given LayoutObject in that new column [*], we may have to discard the old FragmentData entry. [*] One known case is when out-of-flow layout inserts fragmentainers on its own. This may lead to "non-contiguous" chains of FragmentData objects. In the attached test we initially have one column before the spanner and one after it. The anonymous containing block inside the multicol container is represented in both. We get one FragmentData entry with fragmentainer index 0, and one with index 1. Nice. Then we re-lay out, and due to imperfect column balancing (sorry, we keep doing our best, but this may happen), we end up with two columns before the spanner, and one after it. The second column before the spanner is created by the out-of-flow layout machinery, which just adds the fragment for the OOF, and not the anonymous containing block inside the multicol container. The anonymous containing block will then be represented in the first column, but not in the second one, and then it will appear again in the third column (after the spanner). In the first layout we had FragmentData at index 0 and 1. After re-layout we should have one at index 0 and one at index 2, and none at index 1. So we have to make sure that we remove the one at index 1, and then append one at index 2. Bug: 1361902 Change-Id: I49bc3cc8f19ae07189c573884db049046c81278a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4025783 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071674}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!