commit | 159dd88d337c2041f4381399c3833c6859ab1883 | [log] [tgz] |
---|---|---|
author | Hao Liu <haoliuk@chromium.org> | Thu Nov 24 21:00:22 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Nov 24 21:12:29 2022 |
tree | eebeab73629d47cd148c530cbb070de34fd1c7bc | |
parent | f02c2f1a673ef64d1eda5c8c0acbc473c9fdce66 [diff] |
Reland "Expose LCP Render Time for Non-TAO Delayed Images." This is a reland of commit febd038be1ca533233dab67a7da8f7b27ff9a1bf The previous landed CL was reverted because the browser test fails with build linux-chromeos-chrome. The FCP and LCP are expected to be the same in the browser test but they are not. The reason, upon investigation, is with that build, the presentation callback is invoked in the CompositeForTest() and DidNotSwap() code flow which is for single threaded compositor. The timestamp passed in each callback is a base::TimieTicks:Now() taken at the invocation time. Thus different callbacks use different timestamps even they are invoked by the same presentation. FCP and LCP are set by different callbacks, so the timestamps being set as FCP and LCP are different. The fix is simply add a timestamp argument to the DidNotSwap(). A timestamp is taken before and passed to the invocations of all the callbacks. A wpt is also added with virtual test suite config. Original change's description: > Expose LCP Render Time for Non-TAO Delayed Images. > > > This CL exposes render time of Non-TAO images whose render is delayed. > The criterion used implies in such cases, the LCP element is the same > one that makes the FCP. > > See implementation details https://docs.google.com/document/d/1oUESmoyjhOs3n6RMoQNHvMgifXgtoxrxgk89q7YSMPA/edit?usp=sharing. > > Bug: 1345948 > Change-Id: I01c3ea3c3195f203dcd6cd15628df6231e561233 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3993534 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Hao Liu <haoliuk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1071101} Bug: 1345948 Change-Id: I664fbf30a570f546df0dcf54b1a239e1de70c1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027513 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Hao Liu <haoliuk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1075620}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!