commit | 04fd75985e02f45251cc421666f292547cf36cd3 | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Thu Dec 01 18:05:11 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 02 18:05:48 2022 |
tree | 3dcf31d735431b0bcb6f2c4e881a469d709ebb68 | |
parent | db6deadcb828b9f872cc5284667d95ab523e698e [diff] |
css-text-decor: fix crash in ComputeWavyPatternRect for small curves ComputeWavyPatternRect returns a rect representing the bounds of one cycle of the given wavy pattern, expanding the top and bottom edges to the nearest integer y values. In particular, we round the top y value to -∞ with -ceil(abs(y)), which requires us to assert that y<0 to ensure the sign doesn’t flip. Unfortunately this is not always true, because PrepareWavyStrokePath offsets the curve by (0,0.5) to reduce vertical antialiasing. x=0 |------------------------| |. .| | . . | y= 0 __|____.______________.____| 0.5 --|------+-----------.-----| | . . | | . . | | . . | |------------------------| If the amplitude of the curve is small enough, the StrokeBoundingRect can fall entirely between y=0 and y=1. x=0 y= 0 --|------------------------| |. .| | . . | | . . | 0.5 --|------+-----------.-----| | . . | | . . | | . . | 1 --|------------------------| This can happen even if the upper control point itself has y<0, since béziér curves can have tighter bounds than the min/max of all of their points. For example, given the following, the StrokeBoundingRect would be (-1.23219,0.0142169) 4.71437x0.971566, even though cp2 has y=-0.75: start = (-1.125,0.5) cp1 = (-0.375,1.75) cp2 = (-0.375,-0.75) end = (0.375,0.5) The correct assertion is y<0.5, but -ceil(abs(y)) would round small positive y values incorrectly anyway. This patch replaces it with floor(y), which always rounds towards -∞. Fixed: 1393709 Change-Id: I4557a67dd42eb06e1942f3bec4ebcbaeb79ef211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4065062 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1078150}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!