commit | 43c097ec564d814d0974d2d1e1587e37d9c19a19 | [log] [tgz] |
---|---|---|
author | Masayuki Nakano <masayuki@d-toybox.com> | Fri Dec 02 23:20:22 2022 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Sat Dec 03 11:28:00 2022 |
tree | 8b0288eb48976fcf12c2dea9b67a7a5ffd9b8310 | |
parent | ab067dbd52fd4a00971330dd8e355481d8722732 [diff] |
Make `AutoInlineStyleSetter` align setting `text-decoration` style behavior in the CSS mode to the other browsers Gecko wraps selection (and parent elements if entirely selected in them) in new `<span>` element and set `text-decoration`. However, the other browsers tries to reuse selected or parent element which already has `text-decoration` style. The other browsers' behavior is more reasonable from point of view of: * smaller footprint * minimizing to update the DOM tree And aligning the behavior makes it easier to check the compatibility between browsers and us avoid from new test failures aligning other behaviors to the other browsers. If there is an element specifying `text-decoration`, its `text-decoration` declaration should be updated first. If found element is `<i>`, `<s>` or `<strike>`, it should be replaced with new `<span>` because these elements just represents the visual style and we should not use such elements in the CSS mode (bug 1802736). At this time, unless the element has `text-decoration` rules in its `style` attribute value, we the new `text-decoration` style should have the value represented by the removing element (i.e., `underline` for `<i>`, `line-through` for the others). However, if found element is `<ins>` or `<del>`, we should set its `text-decoration` and unless it already has `text-decoration` rules, we need to append corresponding style (`underline` for `<ins>` and `line-through` for `<del>`) too. When setting the values or removing a value from `text-decoration` declaration, the value should be normalized to represent only `text-decoration-line` for compatibility with the other browsers and keeping the implementation simpler. And also the value should be built as the following order: 1. underline 2. overline 3. line-though rather than updating current value with complicated code. Then, the tests can compare with one expectation. Depends on D163188 Differential Revision: https://phabricator.services.mozilla.com/D163429 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1802831 gecko-commit: 4e4cf4947e57f59cb1c1fa1ebed72fbbcccfc0e0 gecko-reviewers: m_kato
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!