commit | b838fa5be31fcc982332899289e84d9e35f8125c | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Jan 12 08:49:18 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Jan 12 09:22:10 2023 |
tree | 350bcc32a507713a144f4049595673f50b3a0041 | |
parent | fe2111adb8769ba2715016d3ede2aaf88cb06710 [diff] |
Improve repeated fixed-positioned layout logic. What we had didn't work if there were nested out-of-flow positioned elements. One thing was that if such nested OOFs caused additional fragmentainers to be created, the fixed-positioned elements wouldn't be repeated in those new fragmentainers. Another problem was that we would end up with duplicate fragments for the same OOF node (in the same fragmentainer!), if that node was nested inside an absolutely positioned node. What triggered this was the double layout of all OOFs, that we used to perform at the last fragmentainer (the one we'd perform when is_known_to_be_very_last_fragmentainer got set to true in LayoutOOFsInFragmentainer()). If any outer absolutely positioned node had another OOFs inside, that inner OOF would be propagated twice, eventually getting duplicate entries in pending_descendants in the next call to LayoutOOFsInFragmentainer(). This could lead to DCHECK failures and crashes. The only reason for doing layout twice for all OOFs in the last fragmentainer, was to finalize the repeated nodes (deep-clone the fragments, and make sure that the last fragment didn't have an outgoing break token). But this isn't really necessary, if we split the finalizing part of NGBlockNode::LayoutRepeatableRoot() into a separate function, that NGOutOfFlowLayoutPart can call on its own. Do that, and move all the logic one step up, to LayoutFragmentainerDescendants(), where we have more control. This way we can resume repetition of nodes, if nested OOFs causes creation of additional fragmentainers. Note that some of the new tests also pass without this CL. Bug: 1399456 Change-Id: I5556873b7bc044c9d5aed6761bade05194b741f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157412 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1091727}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!