commit | e0ed7a50f04e4b8308f064cbb6e391a465608c42 | [log] [tgz] |
---|---|---|
author | Masayuki Nakano <masayuki@d-toybox.com> | Tue Jan 17 23:52:53 2023 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Wed Jan 18 10:38:20 2023 |
tree | ea6132507e2c951193db125f1c7a4fc9b86048a0 | |
parent | ade4b929b2e0698f2fbe95d6f651b3af5d1bf176 [diff] |
Make the style editor handle `<font>` at last when there are multiple preserved styles Height of inline elements are considered with current `font-size` and `line-height`. Therefore, if content in inline elements are taller, the `background-color` does not fill the bigger content background entirely. For solving this issue, Chrome handles styles of `<font>` element as outer-most style. This is reasonable approach, let's follow this. For solving this issue, we can change the order of `PreservedStyle`s at setting the preserved styles. Then, `SetInlinePropertiesAsSubAction` is called with reversed order and apply later style first and applies newer styles to all content in an element which is previously inserted. Therefore, the `<font>` element styles should be last elements of `PendingStyles::mPreservingStyles`. When applying new style, our style editor does not reuse existing `<font>` element, and this causes writing WPT harder. Therefore, this patch also changes the applying range of `<font>` style to wrapping existing `<font>` element if and only if its content is entirely selected. Unfortunately, this approach cannot get exactly same result as Chrome because we insert outer-most `<font>` element first, then, try to apply `background-color`, at this moment, our style editor applies the style to the previously inserted `<font>` element instead of creating new `<span>` element. This behavior is required for compatibility in the other cases. Additionally, changing only this behavior requires a lot of method changes to specify how to handle it. However, this incompatible behavior may not cause any problems in web apps in the wild. Therefore, this patch does not solve this incompatible issue. I think that once we get a bug report caused by this difference, we should redesign how to set multiple inline styles once. Differential Revision: https://phabricator.services.mozilla.com/D166617 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1808906 gecko-commit: b1cd7f16a87b58b578ddff9c4eddfdd09cb162db gecko-reviewers: m_kato
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!