commit | f6f37fd79480c0b6e320caa71e08e992a3f1634c | [log] [tgz] |
---|---|---|
author | Frédéric Wang <fwang@igalia.com> | Mon Jan 23 19:22:16 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jan 23 19:36:51 2023 |
tree | 1bde1eacfbdc6b3843e5ccaad9772f1bdf180e19 | |
parent | 4eba0e18bc2721a8ae32cd62f65e0045af217f89 [diff] |
FontFallbackList::CompositeKey should take current_family->FamilyIsGeneric() into account FontFallBackList::GetShapeCache calculates the key of a FontDescription via FontFallbackList::CompositeKey as follows: 1. Initialize the key's data/hash in FallbackListCompositeKey's constructor. This ignores FontDescription::family_list_ but takes into account FontDescription::generic_family_ via BitmapFields() and AuxiliaryBitmapFields(). 2. Update key's data/hash via FallbackListCompositeKey::Add and FontDescripion::CacheKey for each item of FontDescription::family_list_ As a consequence, this calculation is not sufficient to distinguish FontDescription created from things like font-family: "system-ui" (quoted) and font-family: system-ui (unquoted) [1] [2]. The ShapeCache is still used in canvas and so it is possible to tweak WPT test css/css-fonts/generic-family-keywords-001.html in order to exhibit that issue. This CL modifies FontFallbackList::CompositeKey to ensure that FamilyIsGeneric() is taken into account for each item of FontDescription::family_list_. It also adds the canvas version of the corresponding WPT test mentioned above. [1] The latter specifies a generic font family but the former does not. See https://drafts.csswg.org/css-fonts-4/#family-name-syntax [2] For generic family listed in FontDescription::GenericFamilyType, it is necessary to add another generic family to the font-family so that they use the same FontDescription::generic_family_. For details, see https://docs.google.com/document/d/1nYJzL-MWQrTmf9Z-KscTWuM_5n6-IVdJeEllJ3Appro/edit Bug: 1408485 Change-Id: Iac95ccf0fd345352cce963f77a60818060a40dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176920 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/main@{#1095744}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!