| commit | c3ab769723cb249535a8845cc35af80975b8926d | [log] [tgz] |
|---|---|---|
| author | Steinar H. Gunderson <sesse@chromium.org> | Mon Mar 13 12:53:59 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 13 13:09:30 2023 |
| tree | 1b8f7d2923b314fc127816f7aeab4d9f0f25dc44 | |
| parent | f9cd002c7c8a63d23c08c7916aefcbf4c50995a8 [diff] |
Trim whitespace around CSS custom declarations. There was a spec change a few years back, requiring us to strip spaces and comments from the beginning and end of CSS custom property declarations. We take a slight performance hit: Initial style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 10041 9994 +0.5% [ +0.1%, +0.9%] Encyclopedia 106735 106744 -0.0% [ -0.6%, +0.4%] Extension 132830 133009 -0.1% [ -0.6%, +0.2%] News 42534 42653 -0.3% [ -1.0%, +0.1%] Search 2636 2662 -1.0% [ -1.4%, -0.6%] Social1 23298 23312 -0.1% [ -0.3%, +0.2%] Social2 1039 1042 -0.3% [ -1.0%, +0.4%] Sports 42680 42985 -0.7% [ -1.0%, -0.5%] Video 41971 42134 -0.4% [ -0.6%, -0.1%] Geometric mean -0.3% [ -0.5%, -0.1%] Parse (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 1360 1372 -0.9% [ -1.2%, -0.4%] Encyclopedia 7349 7384 -0.5% [ -0.7%, -0.2%] Extension 1349 1352 -0.2% [ -1.2%, +0.2%] News 7929 7982 -0.7% [ -1.0%, -0.3%] Search 4965 4997 -0.6% [ -0.9%, -0.4%] Social1 14752 14837 -0.6% [ -0.8%, -0.3%] Social2 617 620 -0.4% [ -1.4%, +0.7%] Sports 56182 56318 -0.2% [ -0.6%, +0.0%] Video 34720 35091 -1.1% [ -1.3%, -0.8%] Geometric mean -0.6% [ -0.9%, -0.4%] Recalc style (µs) Before After Perf 95% CI (BCa) =================== ========= ========= ======= ================= ECommerce 11417 11378 +0.3% [ -0.2%, +0.8%] Encyclopedia 83808 84066 -0.3% [ -1.4%, +0.1%] Extension 120362 120394 -0.0% [ -0.7%, +0.3%] News 31566 31549 +0.1% [ -1.2%, +0.5%] Search 242 242 -0.0% [ -1.5%, +0.7%] Social1 17242 17203 +0.2% [ -0.1%, +0.4%] Social2 602 593 +1.4% [ +0.7%, +2.1%] Sports 22817 22874 -0.3% [ -0.5%, +0.0%] Video 25931 25969 -0.1% [ -0.4%, +0.1%] Geometric mean +0.1% [ -0.5%, +0.5%] We save a little bit of RAM, obviously, but not much. Fixed: 1211112 Fixed: 1220144 Change-Id: Ib7656de36d6a94d85ba25ecf60e9879b21c36468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341633 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1116326}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!