commit | 8233b6326d0d3cffccebfe4743a3692857d52696 | [log] [tgz] |
---|---|---|
author | Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com> | Mon Mar 27 18:46:50 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 27 19:00:08 2023 |
tree | 48af7e28332fac94d9e4a12690600d9f6a4b2ba2 | |
parent | 331357d448fcfa956ca2ae36ac41802b2ba80631 [diff] |
[GridNG] Fix computed style values for non-layout subgrids This CL makes some changes in order to round-trip specified values when `subgrid` is specified on a non-subgrid. This necessitated a complete rewrite of how these values are queried for non-grids, as I discovered that the existing implementation improperly expands integer repeats when an auto repeat exists anywhere in the definition. This was an omission in the test cases, so I added various examples of this to grid-template-columns-computed-nogrid.html. The biggest change here is that in order to round-trip the specified values, we need to store some additional data in `NGGridTrackRepeater`. This includes creating repeaters of type `kNoRepeat` for subgrids, which brings them closer to standalone grids. However, this had some implications elsewhere. Layout needed some extra checks for subgrid when it builds the track collections, and placement behaves incorrectly when `track_count_without_auto_repeat_` incorporates these `kNoRepeat` tracks. grid-template-computed-nogrid.html didn't have any cases for integer repeats, so I added a bunch, both with and without auto repeats. Bug: 618969 Change-Id: If348f6b099a9032f067fa2299c9d3444d2f52a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317507 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1122559}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!