commit | 3e81feb63b43e75ee58ecff553b7acf37aef2ab1 | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Mon Mar 20 15:31:36 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 20 15:47:54 2023 |
tree | a35f4c787a4b6e3791ce3848bfcb4b00f1c036bc | |
parent | 1b93b258c8257e5361c2f41c7dd1b1a9e43f8dea [diff] |
[@scope] Introduce RelationType::kScopeActivation We currently match :scope incorrectly: in CheckPseudoScope, we consider the selector as matching if there is *any* activation root that matches. This gives incorrect behavior for e.g. ':scope > :scope', because we can match :scope against different activation roots within the same selector. This is not correct. Instead, the element chosen to represent :scope must remain stable across a given selector evaluation, and then we have to try the whole selector N times for N different roots, in principle. In order to avoid (re)trying the whole selector N times for N activation roots, we prepend a special relation kScopeActivation to any compound that contains :scope and/or &. When we encounter kScopeActivation during selector matching, we try each activation root (in order) as the :scope element, until we find a match. This way we avoid retrying the *whole* selector N number of times: we only retry from the point of the first compound which contains :scope/&. E.g. for '.a > :scope > .b > .c', the selector really looks like the following internally: '.a > :true$:scope > .b > .c' (using $ to represent kScopeActivation). This means we can evaluate the '.b > .c' part normally, without doing any work related to @scope. The kScopeActivation relation is always attached to the :true pseudo-class, and is inserted parse-time as follows: 1. Before the implicit :scope that is prepended with a descendant combinator if the selector is not ":scope-containing". 2. Before the implicit :scope that is prepended to relative selectors. 3a. Before compounds which contain :scope specified by the author. 3b. Before compounds which contain '&' specified by the author. (3b) happens because having '&' in a selector makes it ":scope-containing", and is therefore not guaranteed to otherwise contain :scope. Additionally, '&' behaves like :scope when there is no parent selector, which is the case for @scope rules which have no <scope-start> selector. This CL breaks "@scope (:host)". Another solution must be found for dealing with this (Issue 1418304). [1] https://drafts.csswg.org/css-cascade-6/#in-scope Fixed: 1418014 Bug: 1418304 Change-Id: If46aca89c3ebe83b62bbd1f7c9ffbaa5b5692e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345796 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1119334}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!