| commit | 4a80a1dc449b4d955b431f06cf70888256f74a45 | [log] [tgz] |
|---|---|---|
| author | David Awogbemila <awogbemila@chromium.org> | Wed Mar 29 16:12:48 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Mar 29 16:54:36 2023 |
| tree | d0e0a7598e0b81cdf41de07503556cda7e215bb0 | |
| parent | 5068ba757e255d43846c9e71d1acc3938a61ff25 [diff] |
No scrollend on VisualViewport-only scrolls Currently, we fire scrollend on the document if either the visual viewport and/or the layout viewport is scrolled which isn't the right behavior as VisualViewport-only scrolls don't generate scroll events on the document. The correct behavior is to only fire scrollend on the document if the layout viewport scrolled. This patch achieves the correct behavior by having InputHandler keep track of whether any update on a given viewport scroll applied to the layout viewport or not. At the end of the scroll, this bit is then stored in CompositorCommitData which the main thread will use to determine whether or not to fire scrollend at the document. 3 tests in wpt/dom/events/scrolling/ have been modified because they were based on the expectation that a scroll with 0 delta on the layout viewport would generate a scrollend event. Also, the tests were written to use touch input which is not supported on mac. This is probably one of the reasons the tests fail in wpt.fyi[1]. I've left the use of touch input but added a TODO to rewrite these tests with a different input mechanism. This addresses scrolls handled on the compositor which does not currently include keyboard scrolls. A follow-up patch will be needed to address keyboard scrolls. [1] https://wpt.fyi/results/dom/events/scrolling/scrollend-event-fired-to-window.html?label=experimental&label=master&aligned Bug: 1423149 Change-Id: I4c0083a9232bacfd19e4ec17ee14f044f018080f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362538 Commit-Queue: David Awogbemila <awogbemila@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1123623}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!