| commit | 757cf4eacc17e080eb754c901de51bf939d33536 | [log] [tgz] |
|---|---|---|
| author | Liam Brady <lbrady@google.com> | Tue Apr 25 08:23:29 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Apr 25 08:36:17 2023 |
| tree | ebf8dfdae322010c3a09d25690c0a1438b28b9c3 | |
| parent | d766e0a1b39d3e4ee5f79de1af1ad5bcb005ac3d [diff] |
Fix permissions issue with iframes nested in fenced frames. This CL fixes a bug related to permissions policies in iframes nested within fenced frames. For policies that are not explicitly disabled in a fenced frame, if the fenced frame's document response disallows a permissions policy, it is still allowed in the iframe nested within the fenced frame. It was first found with the Attribution Reporting API policy, but this bug applies to any permissions policy that can be set in a fenced frame. The bug occurred because iframes nested inside of fenced frames were always treated as fenced frames, and their permissions policies were set with `PermissionsPolicy::CreateForFencedFrame()`, which intentionally does not look at parent frames. While this was suitable when permissions policies were completely disabled in fenced frames, it became problematic when permissions started being allowed (including allowing a document to further restrict permissions), and child frames needed to access the embedding fenced frame's permissions policies to know which permissions to disable. After this fix, `PermissionsPolicy::CreateForFencedFrame()` will only be called on a fenced frame root. Subframes nested in fenced frames will now use the `PermissionsPolicy::CreateFromParentPolicy()` method the same way that subframes outside of fenced frame trees currently do. This CL adds WPTs to check that iframes nested in fenced frames have their permissions set as expected. This CL also fixes an issue with client hint code that was causing an iframe nested in a fenced frame to pull the permissions policy from the outermost main frame rather than its fenced frame root. Bug: 1428913 Change-Id: I590425d59a8f19e37313bd3dedf0d56b35c87f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4377538 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1135089}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!