commit | 06b1f3f262450835a9a4560f744f3fbe60fe81f1 | [log] [tgz] |
---|---|---|
author | Michael Wilson <mjwilson@chromium.org> | Thu Apr 27 19:02:51 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Apr 27 19:14:14 2023 |
tree | 431db1d29fe5b220a99b08e7a7e17c7dd94f854c | |
parent | 4d07bf629e65378383a51e23e2a8c177497043cb [diff] |
Check MIDIMessageEvent, don't check undefined objects in WebMIDI WPT The WebMIDI API does not have constructors for MIDIAccess, MIDIInputMap, or MIDIOutputMap. If the call to navigator.requestMIDIAccess() fails all three of these will be undefined references. This results in additional failures logged for user agents which have security policies that prevent navigator.requestMIDIAccess() from working in the WPT test run environment. However, we don't actually know if those tests would pass or not if the MIDIAccess object could be constructed. The tests that require an object should be omitted instead. This CL only adds these objects to the IDL array after the factory method succeeds. User agents that can construct MIDIAccess will test as normal, but agents that cannot will simply omit the tests that require objects. This CL also adds MIDIMessageEvent which was missing from the test, and explicitly adds MIDIPort to the list of objects for completeness. Change-Id: If004cda1a69fdb37097dbf52011e63f8dfa166ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482975 Commit-Queue: Michael Wilson <mjwilson@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1136694}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!