| commit | d148e84c83fb746581a3e3afe956c9bf7af45127 | [log] [tgz] |
|---|---|---|
| author | Hao Liu <haoliuk@chromium.org> | Wed May 17 21:39:36 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed May 17 23:26:20 2023 |
| tree | bbd1fb28e09679f7d2cfe2ae75907f46d43d693d | |
| parent | 95d29d449e082f8cd9324a02645cbac41759bef7 [diff] |
Change web expose navigation id to random UUID string This CL changes the navigation id of the LocalDOMWindow from an int to a random UUID that is a string. The nav id increments each time there is a soft nav or bfcache nav. Now the nav id would change to another random UUID. This is to make the navigation id non-sequential so we can record it into UKM. Things to note 1, The WTF::CreateCanonicalUUIDString() is used, instead of the Crypto::randomUUID(). These 2 are the same. The latter is used only in v8 code and the former is used in all other places. 2, Previously the navigation is an int with a default number. So if the nav id is the default number, we know no soft nav or bfcache nav happens. With nav ids being UUIDs now, the nav id at the LocalDOMWindow creation time is initiated to a UUID no different than other UUIDs generated after each soft nav or bfcache nav. Thus by just looking UUIDs, we no longer know if the current Dom has gone thru soft nav and bfcache nav unless we keep the initial UUID and compare. It is not a problem. Just note the difference. 3, The test case, PerformanceTimelineNavigationIdBrowserTest _NonBackForwardCacheRestore is removed as now the nav id would be re-generated and different regardless navigation type. The other test case PerformanceTimelineNavigationIdBrowserTest _BackForwardCacheRestore is modified accordingly. It now verifies that each bfcache navigation would change the nav id too. Bug: 1370937 Change-Id: Ifb18df3f267ac39e98d868e558758f400222bd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507239 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Hao Liu <haoliuk@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#1145615}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!