| commit | dacb577044e529f24357a450329232aaa1edb823 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Tue May 09 11:27:21 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue May 09 16:10:41 2023 |
| tree | 10728d0ee7f1397966264d825ead4db0e5f15d7e | |
| parent | 1b0f7547b6835bbe6f1ac8f50b610f6bc3713ef5 [diff] |
Pre-paint: Set up properties for missed OOF descendants. Set up paint properties as correctly as possible for ancestors of a missed out-of-flow positioned descendant. OOF fragments may be missed when block-fragmented, when some ancestor between the OOF itself and the fragmentainer isn't represented in that fragmentainer. Previously we'd just miss out on all paint properties specified on such ancestors (e.g. opacity, transforms, clipping). When setting up paint properties in this mode, side-effects will be disabled for the ancestors that we're processing - i.e. we'll leave LayoutObject, PaintLayer and FragmentData alone. We'll just set up the temporary context objects for pre-paint correctly, so that the missed descendants get *their* FragmentData objects set up correctly, with transforms, opacity, etc. Note that, for now we're skipping this for all clip-related properties. We need to fix crbug.com/1442211 first, or we risk clipping content that really should be visible. For other properties like transforms this is less of an issue. Prior to this change, transforms wouldn't be applied at all, while, with this CL, they will, although with a potentially incorrect transform origin. For other properties again, like opacity or filters, this shortcoming is of no concern at all, since they don't depend on the offset or size of the fragment (which we currently get wrong in some cases, due to the bug mentioned). Added a run-time enabled feature kill-switch, just in case. Bug: 1371426 Change-Id: I2fcebaba913907c09b7cd182053aae7fc8689179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4507224 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1141275}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!