commit | 5c4d4be0a483c4e0e892bb1c31dfca6357e9b25d | [log] [tgz] |
---|---|---|
author | Liam Brady <lbrady@google.com> | Tue May 23 22:20:53 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue May 23 22:46:30 2023 |
tree | 8c07601026866428cdbb654d8693caf4ff5a60a1 | |
parent | cc1bc6fb0c1cbf01c4b213f2e7235696cc134952 [diff] |
Fenced frame: permissions refactor to match spec. While writing the fenced frame spec for permissions policy interaction, we decided to change the behavior to only allow a fenced frame to load if the required permissions to load was enabled for *all* origins, instead of just if the permissions were enabled for the origin of the document being loaded into a fenced frame. This makes the spec simpler and eliminates a weird corner case where a fenced frame could fail when trying to navigate itself to a different origin, causing the ad to break. This CL reflects those changes in the implementation. As part of this change, fenced frames created through an API that navigate themselves to a cross-origin page need to know what the list of required permissions was in the config. Currently, the redacted config is not given to document that is cross-origin to the config's mapped url. This CL modifies the behavior to give cross-origin documents access to the config to calculate their permissions policies, but in a way that prevents them from accessing the window.fence APIs. This does that by introducing a new `VisibilityToContent`, `kTransparentForAllOrigins`, which allows both same-origin and cross-origin documents to see a given field. The existing `kTransparent` visibility will now only make fields transparent if the document is same-origin to the mapped url. Change-Id: I00acb013076d527e482b3ce8f4bd0e45a93c5cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4514455 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Liam Brady <lbrady@google.com> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Garrett Tanzer <gtanzer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1148161}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!