commit | 4eab05e5e460d28219d324c13e5adcc94c5db109 | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Mon May 22 17:58:56 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon May 22 18:13:29 2023 |
tree | 3009c662e3647fff93220e51e91192b0464dc8a7 | |
parent | e5037bee6c95f8e2f3fa09ac81719934e3b920e9 [diff] |
Remove FencedFrameConfig URL attribute We're removing what we colloquially refer to as "default mode" in fenced frames, which is where you manually construct a `new FencedFrameConfig()` object with a (usually) non-opaque URL, to use fenced frames without relying on cross-site data from FLEDGE or Shared Storage. If a use-case that requires this mode of fenced frames presents itself in the future, we will re-add it. But for now, this entails: 1. Removing the FencedFrameConfig#url IDL attribute - Handled by this CL - See corresponding spec change: https://github.com/WICG/fenced-frame/pull/88 2. Removing the FencedFrameConfig web-exposed constructor - This will happen in a subsequent CL We're removing the URL attribute of the FencedFrameConfig interface [1] because if fenced frames can only be used with FLEDGE/Shared Storage, the URL member is always "opaque", since the true value depends on cross-site data. An always "opaque"-returning attribute does not add any value to web developers. To carry out this change we must remove tests that rely on observing the FencedFrameConfig#url attribute, as these tests will need to be removed anyways when fully removing "default mode". [1]: https://wicg.github.io/fenced-frame/#fenced-frame-config-interface R=gtanzer@chromium.org Bug: 1123606 Change-Id: Id29e3b9dac9241d84722c3695f59d9865485d4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547401 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1147330}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!