| commit | 5cd37004680e0b3bfab64a2d21f78845fb7391d0 | [log] [tgz] |
|---|---|---|
| author | thefrog <thefrog@chromium.org> | Tue Jun 20 17:39:58 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jun 20 19:00:25 2023 |
| tree | be4174cf2a611882e2322e9c87597d5804780c23 | |
| parent | 03365e3849fbdb7c47e680c45be477ec120c73b9 [diff] |
Revert "[text-fragment] Attempt search for dynamic content" This reverts commit 6bd222a5ff1b875ac739df526a59799ded6b6676. Reason for revert: Likely causing recent builder failures. Example failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/131991/overview Failing: external/wpt/scroll-to-text-fragment/iframes.sub.html Original change's description: > [text-fragment] Attempt search for dynamic content > > Text fragments currently perform up to two searches, one when document > parsing completes and a second attempt when document load completes (if > load wasn't completed at parse complete time). However, pages, often > load content after document load, when content is "dynamically loaded". > One popular example is Mobile Wikipedia, which adds `hidden=until-found` > on collapsed sections in idle tasks after load. This meant > text-fragments couldn't target pages like these. > > This CL attempts to make text fragments work on dynamically loaded pages > by performing a third attempt, if needed. If all directives haven't > matched at load time, a delayed task is scheduled for 500ms that will > request attachment on unmatched directives. TextFragmentAnchor listens > for relevant changes in the DOM and reschedules this task each time a > change is made. At 3000ms it gives up and performs the search to avoid > waiting forever. > > At a high level, this CL tries to separate the state tracking of actions > performed for the first matching directive from the state tracking for > running multiple searches. This is done by introducing a new iteration_ > enum tracking the latter. > > Change-Id: Ie01012935152b12f2d724469010128c7dd34afb8 > Bug: 963045 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4586061 > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1160040} Bug: 963045 Change-Id: I64babfbb5ac1849f3ea3c7bf3fdb41b12390b657 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629649 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: thefrog <thefrog@chromium.org> Commit-Queue: thefrog <thefrog@chromium.org> Cr-Commit-Position: refs/heads/main@{#1160118}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!