commit | 404414b923c3a801a2d641d6d460e09f8384a658 | [log] [tgz] |
---|---|---|
author | Dan Clark <daniec@microsoft.com> | Sat Jul 15 00:35:18 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Jul 15 00:51:35 2023 |
tree | d87b4e80633202a56fd5b10c02ce9ebb0869d47f | |
parent | e971e1b529db72e0cc14983bcab94f1b3d37d7f5 [diff] |
[EditContext] Make EditContext editability inherited via UserModify The editability that nodes receive from having an associated EditContext is currently not inherited. In `HasEditableLevel()` [1] the child node's default value of EUserModify::kReadOnly will be used instead of climbing the ancestor chain to find an EditContext on a parent node. For `contenteditable`, the inheritability is implemented by having `contenteditable` make the node have -webkit-user-modify:read-write or read-write-plaintext-only, which is an inherited property. See `HTMLElement::CollectStyleForPresentationAttribute` [2]. In this CL, we integrate EditContext into that approach. Since the `editContext` property is not reflected in a content attribute, it needs to be done a little differently: we use StyleAdjuster to give the node UserModify if it has an associated EditContext, and invalidate styles in the `editContext` setter to ensure that this change is picked up. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/editing/editing_utilities.cc;l=182;drc=ecac3938ad3a8c0edd2d1a45c2f9c3c7a7a41c2b [2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_element.cc;l=331;drc=6bfe7cd47b0de410cc4c90ffbc873ccfc870077d Bug: 999184 Change-Id: I0599226120a2551a205262ee98342d749ed21d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4642263 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1170804}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!