| commit | e11bd9a904208703cf04f676952e2213784a67bc | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Tue Aug 01 16:28:26 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 01 16:59:40 2023 |
| tree | 51d48acce8fd503a29b4792219cd499928a7f060 | |
| parent | 2d87052e429aafc70c48b5d02b0a6de574f49c4d [diff] |
Printing: Move page size calculation to Blink. This is in preparation for mixed page sizes support (which will be added in an upcoming CL). We need to set the correct size for each individual page during layout. Remove the concept of "*the* page size", since each page can have its own size. Note, however, that we still need a uniform page size to use as the initial containing block, which is used to resolve viewport units, among other things. The spec defines the initial containing block as the page area size of the first page: https://www.w3.org/TR/css-page-3/#page-model As a result of this change, some cleanup in PrintRenderFrameHelper should be possible (in future CLs). For one, we no longer need to lay out everything twice, since we lay out with the correct page sizes in the first layout pass (rather than first using printer defaults, then read out sizes and pargins specified in @page rules, and then lay out again with the correct sizes). It should also be possible to untangle some margin logic in PrintRenderFrameHelper, since Blink now only applies CSS-specified margins when it should (e.g. not if the user has chosen their own margins in the print preview UI). Furthermore, there are redundant fields in WebPrintParams. We no longer need to store a page size or content area size (since we're providing a WebPrintPageDescription now). PrintContext no longer stores a vector of page rectangles. They will instead be calculated when needed. We only used the rectangles when printing with Blink, whereas ChromePluginPrintContext was forced to populate a page_rects_ vector, just so that we could return the correct number of pages. Since the code for calculating the page rectangles has been rewritten, especially when it comes to how additional pages caused by monolithic content is calculated, I added a web test for that, since it turned out that we didn't have a good test for that particular case. No behavior changes intended. Bug: 835358 Change-Id: Ic669071b3e0ac729a467321720e25d6101e7b13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4725066 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1177868}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!