commit | d1202c3cafa1fa7b17742cdd479175e0deda3cb9 | [log] [tgz] |
---|---|---|
author | Camillia Smith Barnes <cammie@chromium.org> | Wed Aug 23 21:28:11 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Aug 23 22:02:44 2023 |
tree | 0962e2e7d5d7fbe63b0eb68157f4fa6412981ba4 | |
parent | b5e916057bcb3464717f0f5d5fa4fb77900fb3bc [diff] |
Shared Storage: Add iframe attribute for response header writes We include the previously added mixin interface `HTMLSharedStorageWritableElementUtils` with boolean attribute `sharedStorageWritable` in `HTMLIFrameElement`. The value of the IDL attribute is plumbed to the new field `blink::mojom::IframeAttributes::shared_storage_writable`, and then `blink::mojom::LocalFrameHost::DidChangeIframeAttributes()` notifies `FrameTreeNode` the attribute value is parsed or changes. We add infra to `NavigationRequest` and `NavigationRequestInfo` to check PermissionsPolicy and plumb the writable value to `network::ResourceRequest`. Since the `URLLoaderNetworkContext::Type` for iframe navigations is `URLLoaderNetworkContext::Type::kServiceWorkerContext` (https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/storage_partition_impl.cc;drc=b27071598a6b291a7319d99ce7aa4af81ebc060f;l=3329), we have to use a workaround to send a `RenderFrameHost` to `SharedStorageHeaderObserver::HeaderReceived()`. Hence we add `network::ResourceRequest::TrustedParams::shared_storage_writable_id`, which in the case of (eligible) iframe navigations will be the existing `NavigationRequest::navigation_id_`, and otherwise -1. This long integer is sent over mojom and can thus be sent back again via `URLLoaderNetworkServiceObserver::OnSharedStorageHeaderReceived()` in order to identify and defer a header's operations, which will then be looked up by id and invoked on iframe commit. This is part of a project to add support to writing to shared storage from response headers. See https://github.com/WICG/shared-storage/pull/70 for more information and https://crrev.com/c/4691573 for a prototype for adding image and iframe attributes. Browser tests are added in https://crrev.com/c/4718688. Bug: 1434529,1218540 Change-Id: I290a8e06cf4824845e12421bbd34906f9399b25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4717613 Reviewed-by: Eric Orth <ericorth@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/main@{#1187498}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!