| commit | 43b0d742a70560488a4348a7601884b2c1bd9b07 | [log] [tgz] |
|---|---|---|
| author | Mason Freed <masonf@chromium.org> | Tue Aug 29 17:29:29 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 29 17:59:55 2023 |
| tree | 744e39e44b60271c7dbcf1505704fbd61d81c3fe | |
| parent | 36ce9f90725a46dc02643f1c1d5da87bb8101903 [diff] |
Rationalize the behavior of SupportsFocus, Is{keybd|mouse}Focusable
This CL cleans up three functions in Element:
- SupportsFocus: true if the element is *capable* of being focused. An
element supports focus if, e.g. it has a tabindex attribute, or it is
editable, or other conditions. Note that the element might *support*
focus while not *being focusable*, for example if the element is
disconnected from the document.
- IsMouseFocusable: true if the element SupportsFocus() *and* is
currently focusable using the mouse.
- IsKeyboardFocusable: true if the element IsMouseFocusable(), *and*
is currently focusable using the keyboard.
Note that each method is a subset of the one above it, by
construction.
This also adds IsScrollableContainerThatShouldBeKeyboardFocusable(),
which returns true for scrollers that should be made keyboard focusable if the feature flag for that behavior is enabled.
This also adds a `DocumentLifecycle::DisallowTransitionScope` to
make sure SupportsFocus() does not update the rendering lifecycle.
Note crbug.com/1474971 and the new baselines for the
video-playback-speed-menu.html test. That focus ring was there due
to a confluence of weirdness in the media controls code, and that
will need to be tackled separately, if desired. The new behavior
might also be ok.
Note that accessibility code is using `SupportsFocus()` to mean
`IsFocusable()`, but prior to this CL, there were cases in which
`SupportsFocus()` returned false and yet `IsFocusable()` returned
true. That has been fixed in this CL everywhere except a11y code,
which still uses `SupportsFocus()`. In addition, to avoid breaking
a11y code, `SupportsFocus()` is still not calling the new
`IsScrollableContainerThatShouldBeKeyboardFocusable()` method, which
means for focusable scrollers, SupportsFocus will be `false` while
`IsFocusable()` will be true. This will be fixed in a followup
CL [2].
This patch borrows heavily from [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4518938
[2] https://chromium-review.googlesource.com/c/chromium/src/+/4813829
Bug: 1444450, 1474971
Change-Id: Ieeb5f0bde2cf2130c19cd15df1bf4f9c0aa21e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4795287
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1189598}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!