| commit | 89bf11b5a57593a1c2788d765318186bfe8dfe0f | [log] [tgz] |
|---|---|---|
| author | Daniel Holbert <dholbert@cs.stanford.edu> | Mon Aug 28 19:55:23 2023 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Tue Aug 29 14:14:22 2023 |
| tree | b3992feafa920a3c9bbac491944fee92ce2edf12 | |
| parent | d6ce716c93f957488ab359797c61407ccab9852d [diff] |
Remove unnecessary div wrapper from some grid ::first-letter/::first-line WPTs, to avoid tripping over an unrelated-to-grid Firefox bug. These tests are trying to validate that the first-line and first-letter pseudos match properly when specified on a grid item, but these tests were testing this slightly awkwardly by checking whether these pseudos can change the color of text that happens to live *in a descendant* of that grid item. That descendant-targeting doesn't work in Firefox right now, due to a longstanding bug with these pseudos[1]. That bug has nothing to do with grid or grid items, however. There's no reason that these tests need to be targeting a descendant to validate that these pseudos match. We can just adjust the test to remove the unnecessary extra wrapper, which then lets us validate more directly that they do in fact properly change the color of the first letter or first line directly in that grid item. (Note that we do have other WPT coverage[2][3] for the known Firefox pseudo-matching-text-in-descendants bug, as well.) [1] https://bugzilla.mozilla.org/show_bug.cgi?id=317081 [2] https://wpt.fyi/results/css/css-pseudo/first-line-on-ancestor-block.html [3] https://wpt.fyi/results/css/css-pseudo/first-line-change-inline-color.html Differential Revision: https://phabricator.services.mozilla.com/D186870 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1841318 gecko-commit: 7df10ffc03578567afa80bb6a9c92328fee87e56 gecko-reviewers: emilio
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!