| commit | bd6beebed94767151e7e42c26d086545e35df03c | [log] [tgz] |
|---|---|---|
| author | Greg Thompson <grt@chromium.org> | Fri Sep 01 09:10:14 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Sep 01 09:18:22 2023 |
| tree | ad8939ab9fbe237f07e64264658ba8f1b7f9f28a | |
| parent | 9ca3e5b15cb4fc4cd94a7e4f7e1497e4967d5a12 [diff] |
Revert "Remove SK_USE_LEGACY_BLUR_IMAGEFILTER staging flag" This reverts commit 069d3d9db0b3093fec0edee412abfbdb9316f460. Reason for revert: Linux MSan failures; see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/42742/overview. Original change's description: > Remove SK_USE_LEGACY_BLUR_IMAGEFILTER staging flag > > With the removal of this flag, CPU-based blurs will now respect the > SkTileMode passed to the blur image filter. Both GPU and CPU blurs > will tend to have more optimal image sizes (smaller) when using > kDecal. kDecal should also use fewer renderpasses. There is a > temporary regression in image size and renderpasses for other tile > modes but this is a required step in the overall blur refactoring. > > It also fixes a bug where decal would be applied to the intersection > of both the filter region and primitive subregion when performing > blurs in SVGs. This is why there are larger changes to the > `effect-reference-subregion`: the blur is able to read the hidden color cells of the input image, some of which are red so the overall blur color shifts from green to brownish. > > Most viz pixel tests have benign updates. However, the blur_filter_with_clip test is meant to have clamped content. The SW > expected image had baked in the previous limitation of decal-only > blurs which is no longer the case. However, the software_renderer > compositor seems to be sizing images a little off so the clamp is only > applying to the top and left edges. Now the new expected image is > just half wrong :) > > Chromium is still relying on deprecated behavior for clamped blurs > where it doesn't specify the clamping geometry with the image filter. > This will require more changes but would likely get around the issue > with how the software_renderer prepares the images to be blurred. > > Numerous ash pixel tests had to be updated, but I couldn't spot any > meaningful differences in their content. My guess is that the widgets > and windows all had some amount of blur use, so this change touched > everywhere. > > Bug: b/294100597 > Bug: b/40040586 > Change-Id: I67d5840113e87cfbed1d3a2c4d624c8216991775 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4818347 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > Cr-Commit-Position: refs/heads/main@{#1191026} Bug: b/294100597 Bug: b/40040586 Change-Id: I9e8a7b8d6d046e68de3324a4a9f1a11c82897baa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4835971 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Owners-Override: Greg Thompson <grt@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1191235}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!