commit | e83b508b03cbdbcdc51a22b3fa935251503673de | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Mon Sep 04 07:44:44 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Sep 04 08:35:09 2023 |
tree | 70f4f68fa20de0f4586e60d3ba99f00e5bdcc62f | |
parent | bd6bcc0dbd1facb4c8c9ad4b8fdaf31e4e33a620 [diff] |
Locate parent fragment of nested OOF multicol correctlier. Fix a mistake from crrev.com/c/4798090 . We shouldn't require the multicol container that we stop at to be in-flow. The only actual code change here is precisely that: We will still stop searching when an entry in the containing block chain is in-flow and the containing block of that one is a fragmentation context root (e.g. multicol container), but don't require this fragmentation context root to be in-flow. It's the right container of the inner OOF multicol regardless of that. The rest of the code changes are just an attempt to make it a bit more readable. We were skipping one element in the chain (the containing block of the OOF input multicol container box), and went directly to the containing block of that one. It really shouldn't matter in practice, because if the containing block (CB) of the OOF input multicol container box also is a multicol container, we're not going to stop there anyway, because the fragments of the OOF input box still must belong higher up in the tree, participating in an outer fragmentation context, because we can be sure that CB isn't the outermost fragmentation context, because in that case we would still be inside its layout algorithm, and therefore wouldn't have to mutate its fragment (since it wouldn't exist yet), so we won't be here in such cases. But, unlike this paragraph of explanation, the code is a bit easier to follow, if we start at the input box itself. Bug: 1475385 Change-Id: Ifeb61ac1633b9a10a2a72b2871f817bfd24855d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4836053 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1191979}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!