| commit | 8bb6f00a4893963f3f9a03d64bfaeaca9de76f66 | [log] [tgz] |
|---|---|---|
| author | Aaron Krajeski <aaronhk@chromium.org> | Fri Sep 22 13:32:28 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Sep 22 13:50:46 2023 |
| tree | 6249976827284fb8401e53dc3d2b07f84277345f | |
| parent | 5f0fba3215492e89b9021bf3bfb9dac63e8fd7c9 [diff] |
Clamp out-of-gamut legacy rgb values Previously legacy rgb color parameters were clamped to [0, 1] (which is serialized to [0, 255], for legacy reasons) at parse time. Refactoring the color parser overlooked this, as serialization did the clamping. This lead to a corner case where out-of-gamut values could be parsed and stored, and would be serialized as normal. The out-of-gamut stored values will interact with alpha blending, causing alpha to seem higher than it is (see bug). See https://chromium-review.googlesource.com/c/chromium/src/+/4879797 to confirm that the regression test is working as expected. I removed Color::IsLegacyColor() in favor of Color::IsLegacyColorSpace(Color::ColorSpace) because they both do exactly the same thing and the latter is slightly more useful. I also took out the logic to take care of non-finite values in serialization of legacy colors as the spec is now explicit that they should be clamped. css1/units/color_units.html is an invalid test that was never meant to have an image baseline. This is made clear if you read the text within said test. The reason it is failing for this CL is because it was expecting the very behavior that caused the bug in crbug.com/1483736. The new test out-of-gamut-legacy-rgb.html verifies this much more clearly. The image output also only renders half of the page. It is merely meant to validate that different color inputs should be rendered the same way within the page. This is already well tested in WPT, for example: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-color/rgb-001.html https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/css/css-color/rgb-002.html All that stated, I think this test is slowing down development and not providing any value, so I deleted it. The fact that it already had four different baselines was a good sign that it was just blindly being rebaselined. Bug: 1483736 Change-Id: Ibb707f29638356bb0835903e6a56b73ad0969496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878299 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1200189}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!