| commit | af15aec4a7076fbd08c08c989a27d690faa5a4d5 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Tue Sep 26 23:03:34 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Sep 26 23:20:10 2023 |
| tree | 55cc0b9c20f63f6d27d5957c6af2afca4f18b22d | |
| parent | 05fc184cc9607d866464e950aee6d17e6227eb97 [diff] |
Never break before a float resumed after a break. Always process all incoming inline break tokens that establish a parallel flow for a fragmented float or overflowed block-in-inline. The orphans implementation works so that if we run out of space in a fragmentainer, we'll still keep on laying out a few more lines, to figure out if we should break further up (rather than exactly where we run out of space), in order to honor widows. We count the number of lines laid out. The fix is to make sure that inline break tokens that just contain a resumed float or block-in-inline (in a parallel flow) leave this counter alone. Otherwise we risk breaking before even getting around to resuming the block node inside, which means that it wouldn't be added to the fragment tree at all. Add DCHECKs after layout of a block to make sure that we don't break at a location where we'll be unable to resume correctly. This also includes DCHECKing block break tokens, not just inline break tokens. There are no known issues for block layout ending up in this state, but it would be equally bad if it happens. This also fixes a correctness issue that was introduced by CL:4874801. Counting resumed floats as line boxes for orphans / widows consideration caused us to break prematurely in some cases. If this premature break is before an actual line box, we get a correctness issue (breaking too soon). If this premature break is before a resumed float, the fragment tree would be in a bad state, which could lead to crashes. Add a test for both a crash and the correctness issue. Bug: 1486252 Change-Id: I764c12e01540f7ceb437fb4aca787c9424ddfa48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4891832 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1201849}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!