commit | 485bea6bb6e13e13959db7af8627bbca5518284c | [log] [tgz] |
---|---|---|
author | Liam Brady <lbrady@google.com> | Fri Dec 08 20:15:48 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 08 20:35:12 2023 |
tree | 68a1b3fe57265bd9df73e2e9044e989ff993964b | |
parent | 27143e969830f922c101e8af90c5e70fa801bbf8 [diff] |
Fenced frame: Fix activeElement and hasFocus(). Currently, when a fenced frame has focus, its embedder's `document.activeElement` will just return the body rather than the fenced frame. Similarly, `document.hasFocus()` will return false when a child fenced frame has focus, whereas it will return true if a child iframe has focus. There's no security reason to not have fenced frames behave like iframes in this case (the renderer has this information anyway, nothing is leaked across a fenced frame boundary, and focus is already gated to prevent cross-channel communication). This CL modifies `FrameTree::Parent` to be able to traverse to the parent of an HTMLFencedFrameElement. It does this by getting the HTMLFencedFrameElement's owner's document's frame instead of the frame's parent, which is null for a HTMLFencedFrameElement's frame. This change will not affect anything inside of a fenced frame tree, since a fenced frame root doesn't have access to its embedder's document. As a result, when `FocusController::FocusedFrameOwnerElement` traverses up a frame tree, it will be able to get the parent of an HTMLFencedFrameElement when it's the focused element, and will be able to properly check that `current_frame' is one of its ancestors. We could previously make the assumption that if a frame tree doesn't have focus, none of its children have focus. That assumption is broken with MPArch. To fix that, this CL refactors `FocusController::IsDocumentFocused` to account for the fact that an HTMLFencedFrameElement can have focus while its embedder's frame tree loses focus. Change-Id: Ic7a1823113e2d9c4a22bff2b7b7b7df85c089d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892841 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liam Brady <lbrady@google.com> Cr-Commit-Position: refs/heads/main@{#1235177}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!