| commit | c938ea475e0a2c34f40fe2d47ceb5c678d0b4231 | [log] [tgz] |
|---|---|---|
| author | Frederic Wang <fred.wang@free.fr> | Fri Oct 06 12:10:54 2023 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Fri Oct 06 16:03:10 2023 |
| tree | 656ce7ba31283530cc6d64c2e8371fbf39ba3121 | |
| parent | e8acac6c3be34d6c4cf25d9dc1798af51c9897a3 [diff] |
Handling of custom properties when enumerating getComputedStyle(). After bug 1840478, non-inherited custom properties using their initial values are represented as absent from `ComputedCustomProperties` in order to save memory. Wherever the values of such properties are requested, it is necessary to fallback to any registered initial value. However, this makes difficult to properly enumerate custom properties for exposure via the `CSSStyleDeclaration.item()` API and indeed our current implementation only exposes the properties actually present in `ComputedCustomProperties`. Additionally, such a representation conflicts with pre-existent representation of guaranteed-invalid values as absent values, causing some issues e.g. bad handling of invalid at computed-value time [1] [2]. This patch changes `ComputedCustomProperties` so that registered initial values are always stored in the `non_inherited` map, immediately fixing the issue with `CSSStyleDeclaration.item()` and preparing follow-up work on guaranteed-invalid values. To avoid excessive increase of memory usage, the `non_inherited` map becomes ref-counted. The associated Stylist contains an up-to-date ComputedCustomProperties with registered custom properties that have initial values, and the `non_inherited` map can generally just be shallow-cloned from it. A new test `get-computed-style-enumeration.html` is added to make sure custom properties are correctly exposed when enumerating `CSSStyleDeclaration` as a list. A similar but more restricted version already exists: `cssstyledeclaration-registered-custom-properties.html`. Two test cases are also added to `determine-registration.html` in order to cover some issue previously detected during the review of `get_custom_property_initial_values`. [1] https://drafts.csswg.org/css-variables-2/#invalid-at-computed-value-time [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1855946 Differential Revision: https://phabricator.services.mozilla.com/D189999 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1855629 gecko-commit: 4556cc6bbefbede9eaef1becd9c598b9e90a50e8 gecko-reviewers: emilio
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!