commit | 474e77a2933ac1c860661a01d47908e13d5603bc | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Tue Oct 10 03:31:20 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 10 03:48:52 2023 |
tree | eaccf3d9af8fe695c82cfee709f03804f45ae0eb | |
parent | b9409d913a61305643a997cc49678216fb6b2815 [diff] |
DOM: Fix Observable error reporting behavior Observables need to have the behavior where errors — via `Subscriber#error()` or `throw`n exceptions — are "reported" to the global [1] in two interesting corner cases: 1. After a subscription is already closed, yet the subscribe callback continues to generate via `Subscriber#error()` or by `throw`ing an exception 2. When `Subscribe#error()` is called but there is no `Observer#error()` handler passed into the `subscribe()` method. In this case, we must surface error in *some* way, and we do this by reporting the exception to the global. This CL also adds "detached document" tests, ensuring that none of the `Observer` dictionary callbacks (`next()`, `complete()`, `error()`) are invoked in a detached context, and further asserts that when `Subscriber#error()` is invoked from a detached context specifically when there is no `Observer#error()` handler passed-in, no exception is reported to the global, because it is detached. After this CL, there is a single remaining failing test of the existing Observable constructor test. This asserts that `throw`n errors are pushed to the Observer's `error()` handler if it exists, instead of unconditionally "reported" to the global — this is because if the `error()` handler does exist, that is the proper channel to funnel it through. A subsequent CL will fix this behavior. [1]: https://html.spec.whatwg.org/C#report-the-exception R=masonf@chromium.org Bug: 1485981 Change-Id: I066c17dde65ad0ae14be09c9abae129d02601237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4919191 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1207428}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!