| commit | a32f758c4d57b510800e6a661d955f97309ba8f8 | [log] [tgz] |
|---|---|---|
| author | Phillis Tang <phillis@chromium.org> | Tue Oct 10 18:13:04 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 10 18:35:31 2023 |
| tree | c36fd67824d418689e330afdc58f60e78daece5d | |
| parent | f3a84a31e309f9e7ad7e85122323d344ad80a04a [diff] |
Revert "Recalculate style before setting ICB size for printing." This reverts commit f992984634e8ffc2a9faba835da87085d7a79916. Reason for revert: Causing PrintBrowserTest.NoResizeEvent to fail on Linux. Example build: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/38907/overview Original change's description: > Recalculate style before setting ICB size for printing. > > A zoom factor used when viewing a webpage on screen may have been set in > computed style. This would affect @page margin resolution incorrectly > when entering print mode, which in turn would result in an incorrect > initial containing block size. To fix this, recalculate style before > calculating the page area size. > > Since we now recalculate style before setting any initial containing > block size for printing at all, viewport units will not be resolved > correctly. So make sure that they get calculated before laying out. This > used to be triggered by calling LayoutViewportWasResized(). It turns out > though, now that we need to do this unconditionally before the first > layout, that LayoutViewportWasResized() does more than we want. For > printing, we don't need to re-evaluate media queries, and we do not want > a resize event to be fired. Therefore, split the viewport units dirtying > into a separate function. Introduce a lambda in > ForceLayoutForPagination() to avoid repetitive code. > > Make PrintBrowserTest.NoResizeEvent more evil, by modifying its resource > HTML file to use a named page, and also a wide DIV. This would make the > test fail without this CL. > > Add external/wpt/css/printing/ to the scalefactor200 virtual test suite. > Three other tests (the already existing page-margin-xxx tests) would > also fail without this fix, but add a test for this specific issue > (abspos) as well. > > Bug: 1488751, 1486499 > Change-Id: If42211ddb6aadc49dcdee71ccd9597aa2818a672 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922711 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1207513} Bug: 1488751, 1486499 Change-Id: I84bcbf4acea734cea3a495ea9ac78399c8801345 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4927588 Owners-Override: Phillis Tang <phillis@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Phillis Tang <phillis@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1207774}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!