| commit | bedf0df75dfabcffb8601c9fe1c8ff53716d4934 | [log] [tgz] |
|---|---|---|
| author | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Oct 19 21:43:01 2023 |
| committer | GitHub <noreply@github.com> | Thu Oct 19 21:43:01 2023 |
| tree | 5d890721fb27b1193c9c3926526549810edb9a61 | |
| parent | ff48f1e16f44d32e1805a085342c197a4966b66c [diff] |
Store additional FragmentData entries in a vector. (#42588) This turns NGPhysicalFragment::GetFragmentData() from O(n) into O(1), which improves both pre-paint and paint when there are many columns / pages involved. The new multicol-many-columns.html performance test: RunPrePaintLifecyclePhase(): 273ms -> 6.48ms RunPaintLifecyclePhase(): 1065ms -> 5.76ms Improvements can also be seen in the tall-content-short-columns.html in perf_tests/layout/multicol/. It goes from 3.9 runs per second to 26 runs per second. Storing the vector in LayoutObject would be the most straight- forward solution, but in order to not increase memory usage for every LayoutObject in the world, keep storing a simple FragmentData pointer in LayoutObject, and add additional entries to the new vector in FragmentData::RareData. Only the first fragment will populate this vector. There are DCHECKs for this. Subclass FragmentData as FragmentDataHead to provide container class functionality. During pre-paint, when locating existing or creating new FragmentData entries, avoid unconditionally looping through the FragmentData entries and comparing fragmentainer indices (that was one of the O(n^2) causes). For block fragments we can just use the index of the physical fragment as the fragment data index. For non-atomic inlines, it's a bit more complex, though, especially if the inline formatting context is non-contiguous - but that should be pretty rare. The old code had bugs here, which are now fixed. Some of the new tests, but not all, used to fail. Bug: 1478119 Change-Id: I9aad842d221e2ab2329fe818e0b45148bb4ddfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4946655 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1212107} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!