| commit | 92c259135697d6b4a50425200475f0a7beb613b5 | [log] [tgz] |
|---|---|---|
| author | Xiaochen Zhou <xiaochenzh@chromium.org> | Fri Oct 27 15:20:57 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Oct 27 15:40:25 2023 |
| tree | 96f9d38962df62954915145b8bbf55962db7d1e3 | |
| parent | e83deaa539b2c3d5d02386b8b7ef0ef10079fbe5 [diff] |
Protected Audience: Enable leaveAdInterestGroup() without arguments in urn iframes and ad components. This change has two parts: 1. A bug fix: leaveAdInterestGroup() without arguments currently does not work from urn iframe, but it should. 2. An enhancement: enable leaveAdInterestGroup() without arguments from ad component frames. This is guarded by a default-off feature flag. Before this change, leaveAdInterestGroup() without arguments only works for frames loading main ads in fenced frames tree. When calling leaveAdInterestGroup() without arguments, renderer will end up calling LeaveInterestGroupForDocument(). The check in this function on whether leaveAdInterestGroup is allowed to be called without arguments is moved to browser. This is because we do not have a good way to check whether a frame is an urn iframe at renderer. If the set up does not allow it: - behavior before this CL: throw a JS type error "owner and name are required outside of a fenced frame." - behavior after this CL: show a console error "Owner and name are required to call LeaveAdInterestGroup outside of a fenced frame or an opaque origin iframe." The web platform test checking this JS type error is removed. The console error is covered in browser tests. Please let me know if this looks good, or should we just return without showing any error instead. To enable it for ad components, ad auction data is copied to ad components in `AssignFencedFrameURLAndInterestGroupInfo()`. Previously, it is only copied to the main frame's fenced frame properties. Added browser tests. The support for leaving from ad component frames is gated on a default-off feature flag. Bug: 1485219 Change-Id: I3e47423db99771e2823b3ff00449bb843efa8aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4879697 Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Garrett Tanzer <gtanzer@chromium.org> Reviewed-by: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/main@{#1216114}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!