| commit | 1ca04ef3ebabee87b18d9aaddc76f7053de37925 | [log] [tgz] |
|---|---|---|
| author | Koji Ishii <kojii@chromium.org> | Thu Oct 19 18:37:57 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Oct 19 18:56:55 2023 |
| tree | 351743b947735e8e5d9c8146f5587bde5ff8248c | |
| parent | c5841bb7a7ba1152165fb25fbba666ae0f9ff8d9 [diff] |
[text-spacing-trim] Support quotation marks Quotation marks are one of the code point that are most complicated, because of the Unicode unification unified Latin curly quotes and CJK fullwidth quotes. This patch detects if the font has: * Whether fullwidth glyphs or not. * Whether they're open/close glyphs or not. and apply open/close types if both are true. Otherwise they are narrow open/close. They're commonly used in Chinese, and that Chinese fonts often assign fullwidth glyphs, while most Japanese fonts prioritize the Latin usage and thus assign Latin proportional glyphs. In vertical flow, some Chinese fonts assign bracket glyphs, so that it preserves semantics rather than glyph shapes. Japanese glyphs are most diverged, there are too many variations. Adobe's Japanese convention uses the OpenType `fwid` feature to switch between Japanese and Latin glyphs, and that the behavior of the vertical upright glyph without the `fwid` is undefined. Other vendors take other approaches. Bug: 1463891 Change-Id: Ie9dee55ff8f9fbd35e72288db7c3c37fc668b531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4938492 Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1212282}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!