| commit | 0fef73f2528f28ed7e8ea0c203f38ca092027f85 | [log] [tgz] |
|---|---|---|
| author | David Bokan <bokan@chromium.org> | Wed Nov 01 15:24:16 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Nov 01 15:45:38 2023 |
| tree | f3cf4a784cb7bf75ee85a312ade004ea174d42f1 | |
| parent | 82eca3d201941c56fa1c5da9bddb45dc638b2552 [diff] |
Ensure restarted animations don't clobber start time The bug here occurs because of a race. Blink Animations can be invalidated for all sorts of reasons and they require cancelling the current cc::Animation and starting a new one. When this happens, the new cc::Animation will use the start time that was received for the original Animation. The race condition occurs when the Blink Animation is invalidated before a start time is received. In that case, the Animation starts playing on the impl thread but the new Animation is created without a start time, leading to the Animation starting from the beginning, causing a stutter effect. Additionally, animation events generated on the impl thread when Blink invalidates an animation are dropped since the main thread counterpart is gone by the time of the events arrive. This CL fixes the issue by making Blink recreate the compositor animation with the same id and setting a bit on it to make it reuse the start time from the compositor animation when it is pushed. The animation also reuses the compositor group id on a restarted animation so that animation events are routed back to the blink::Animation correctly. Bug: 1445090 Change-Id: I8e91bdbf8e22b00cd6025d21aa2a982ad4742d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605129 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1218221}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!